fix(ui): validate OOBM is enabled before allowing HA on KVM hosts (#13605) - #13647

ui/src/components/view/ActionButton.vue:181

• execAction references this.item, but ActionButton doesn't define an item prop/data/computed. This means record will never fall back to the clicked row item and will also trigger Vue warnings about accessing undefined instance properties. Prefer deriving record from resource and assigning action.resource from the same value to keep downstream action handling consistent.

    execAction (action) {
      action.resource = this.resource
      const record = this.resource || this.item
      if (action?.api === 'disableOutOfBandManagementForHost' && (record?.hostha?.haenable === true || record?.hastate === 'Enabled')) {

ui/src/components/view/ListView.vue:658

• The <template v-if="column.key === 'clustername'"> line lost its indentation, which makes this block inconsistent with the surrounding template and may violate Vue/ESLint formatting rules.

<template v-if="column.key === 'clustername'">

ui/src/components/view/ListView.vue:696

• The updated account-column rendering has two functional regressions: (1) for PrjAcct-* values outside /quotasummary, nothing is rendered (no v-else fallback), leaving the cell blank; (2) the /quotasummary link is created even when record.accountid is missing and without the previous 404-route guard, which can produce links to invalid routes.

        <template v-if="text">
          <template v-if="!text.startsWith('PrjAcct-')">
            <router-link
              v-if="$route.path.startsWith('/quotasummary')"
              :to="{ path: `${$route.path}/${record.accountid}` }">{{ text }}</router-link>

ui/src/config/section/infra/hosts.js:201

• This new UI guard hides the Disable OOBM action when Host HA is enabled on KVM, but it doesn’t implement the PR/issue requirement of hiding (or blocking) the Configure HA / Enable HA actions when OOBM is not enabled on KVM hosts. Either update the HA action show predicates (e.g., for configureHAForHost / enableHAForHost) to require record?.outofbandmanagement?.enabled === true on KVM, or adjust the PR description to match the actual UI change.

      show: (record) => {
        if (record.hypervisor === 'KVM' && record?.hostha?.haenable === true) {
          return false
        }
        return record?.outofbandmanagement?.enabled === true

api/src/main/java/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForHostCmd.java:84

• listHAResources(...) can return multiple HAConfig entries and the order is not guaranteed; checking only haConfigs.get(0) can allow disabling OOBM even when another HAConfig for the host is enabled. This should reject the operation if any Host HA config is enabled.

        if (host.getHypervisorType() == HypervisorType.KVM) {
            java.util.List<org.apache.cloudstack.ha.HAConfig> haConfigs = haConfigManager.listHAResources(host.getId(), HAResource.ResourceType.Host);
            if (haConfigs != null && !haConfigs.isEmpty()) {
                if (haConfigs.get(0).isEnabled()) {
                    throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Cannot disable Out-of-Band Management (OOBM) because HA is currently enabled on this KVM host. Please disable HA first.");

api/src/main/java/org/apache/cloudstack/api/command/admin/ha/ConfigureHAForHostCmd.java:112

• Same as EnableHAForHostCmd: this OOBM prerequisite only checks HypervisorType.KVM, but the underlying KVM HA provider also targets LXC. This can allow configuring Host HA for LXC without OOBM enabled.

        if (host.getHypervisorType() == HypervisorType.KVM) {
            if (!outOfBandManagementService.isOutOfBandManagementEnabled(host)) {
                throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Cannot configure HA on KVM host because Out-of-Band Management (OOBM) is not enabled.");
            }
        }

api/src/main/java/org/apache/cloudstack/api/command/admin/ha/EnableHAForHostCmd.java:42

• Import ordering is inconsistent within this file: com.cloud.* imports are grouped first, but com.cloud.hypervisor.Hypervisor.HypervisorType is placed after the org.apache.* imports. This can break style checks and reduces readability; keep com.cloud.* imports together.

import org.apache.cloudstack.context.CallContext;
import org.apache.cloudstack.ha.HAConfigManager;
import org.apache.cloudstack.ha.HAResource;
import com.cloud.hypervisor.Hypervisor.HypervisorType;
import org.apache.cloudstack.outofbandmanagement.OutOfBandManagementService;
import javax.inject.Inject;

api/src/main/java/org/apache/cloudstack/api/command/admin/ha/EnableHAForHostCmd.java:104

• The new OOBM prerequisite is applied only to HypervisorType.KVM, but KVMHAProvider treats both KVM and LXC hosts as eligible only when OOBM is enabled. As-is, the API can still enable/configure Host HA on LXC without OOBM, leading to an invalid HA configuration.

        // --- YOUR NEW GUARDRAIL ---
        if (host.getHypervisorType() == HypervisorType.KVM) {
            if (!outOfBandManagementService.isOutOfBandManagementEnabled(host)) {
                throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Cannot enable HA on KVM host because Out-of-Band Management (OOBM) is not enabled.");
            }

api/src/main/java/org/apache/cloudstack/api/command/admin/ha/ConfigureHAForHostCmd.java:45

• Import ordering/formatting is inconsistent here (extra blank line, and com.cloud.hypervisor... is placed after org.apache...). Keeping com.cloud.* imports grouped before org.apache.* aligns with the existing style in this file and avoids potential style-check failures.

import org.apache.cloudstack.ha.HAConfigManager;
import org.apache.cloudstack.ha.HAResource;
import org.apache.cloudstack.outofbandmanagement.OutOfBandManagementService;
import com.cloud.hypervisor.Hypervisor.HypervisorType;


import javax.inject.Inject;

api/src/main/java/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForHostCmd.java:43

• com.cloud.hypervisor.Hypervisor.HypervisorType is a com.cloud.* import but is placed after the org.apache.* imports. This breaks the existing import grouping in this file (all other com.cloud.* imports are at the top) and can trigger style-check failures; please keep com.cloud.* imports together.

import org.apache.cloudstack.outofbandmanagement.OutOfBandManagementService;
import org.apache.cloudstack.ha.HAConfigManager;
import com.cloud.hypervisor.Hypervisor.HypervisorType;
import org.apache.cloudstack.ha.HAResource;